Make the default S3 buffer size depend on the available memory. #21299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the default S3 buffer size is 100MB, which can be a lot for small heaps. This pull request updates the default to be 100MB for heaps that are greater than 2GB and 5% of the heap size otherwise.
tlrx
reviewed
Nov 3, 2016
| /** | ||
| * buffer_size | ||
| * @see Repositories#BUFFER_SIZE_SETTING | ||
| */ | ||
| Setting<ByteSizeValue> BUFFER_SIZE_SETTING = | ||
| Setting.byteSizeSetting("buffer_size", new ByteSizeValue(100, ByteSizeUnit.MB), | ||
| Setting.byteSizeSetting("buffer_size", DEFAULT_BUFFER_SIZE, |
There was a problem hiding this comment.
The other BUFFER_SIZE_SETTING (~ line 111) must also be updated.
(I hate those settings overrides...)
There was a problem hiding this comment.
Good catch! I pushed an additional commit.
|
LGTM |
|
LGTM 2 |
jpountz
added a commit
that referenced
this pull request
Nov 3, 2016
Currently the default S3 buffer size is 100MB, which can be a lot for small heaps. This pull request updates the default to be 100MB for heaps that are greater than 2GB and 5% of the heap size otherwise.
clintongormley
added
:Distributed/Snapshot/Restore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the default S3 buffer size is 100MB, which can be a lot for small
heaps. This pull request updates the default to be 100MB for heaps that are
greater than 2GB and 5% of the heap size otherwise.