Debian: configure start-stop-daemon to not go into background #21343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On ubuntu 14.04, which uses upstart, where as our debian package uses sysvinit, there is no stdout/stderr message printed when starting up, because the start-stop-daemon swallows it. As Elasticsearch is started to daemonize, we can remove the background flag from the start-stop-daemon and thus see, if the system does not have enough memory for starting up - something that happens often on VMs, since Elasticsearch 5.0 uses 2gb by default instead of one. Relates elastic#21300 Relates elastic#12716
spinscale
added
the
:Delivery/Packaging
nik9000
approved these changes
Nov 4, 2016
|
The change looks good to me, I don't see any ill consequences of it, but I would like to test it before this is merged. I will test right now. |
|
@spinscale With this change when you start the service, it prints the output to the console; that's really helpful and way better than what we had before. I'm surprised that it doesn't print the output to |
|
Not really, because in |
|
Okay, thanks for the explanation and for this PR. |
spinscale
added a commit
that referenced
this pull request
Nov 7, 2016
…21343) On ubuntu 14.04, which uses upstart, where as our debian package uses sysvinit, there is no stdout/stderr message printed when starting up, because the start-stop-daemon swallows it. As Elasticsearch is started to daemonize, we can remove the background flag from the start-stop-daemon and thus see, if the system does not have enough memory for starting up - something that happens often on VMs, since Elasticsearch 5.0 uses 2gb by default instead of one. Relates #21300 Relates #12716
spinscale
added a commit
that referenced
this pull request
Nov 7, 2016
…21343) On ubuntu 14.04, which uses upstart, where as our debian package uses sysvinit, there is no stdout/stderr message printed when starting up, because the start-stop-daemon swallows it. As Elasticsearch is started to daemonize, we can remove the background flag from the start-stop-daemon and thus see, if the system does not have enough memory for starting up - something that happens often on VMs, since Elasticsearch 5.0 uses 2gb by default instead of one. Relates #21300 Relates #12716
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On ubuntu 14.04, which uses upstart, where as our debian package uses
sysvinit, there is no stdout/stderr message printed when starting up,
because the start-stop-daemon swallows it.
As Elasticsearch is started to daemonize, we can remove the background
flag from the start-stop-daemon and thus see, if the system does not have
enough memory for starting up - something that happens often on VMs, since
Elasticsearch 5.0 uses 2gb by default instead of one.
Relates #21300
Relates #12716
I'd appreciate few more hints of what could go wrong with this approach that I may be missing.