Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't reset non-dynamic settings unless explicitly requested #21646

Merged
merged 4 commits into from
Nov 18, 2016
Merged

Don't reset non-dynamic settings unless explicitly requested #21646

merged 4 commits into from
Nov 18, 2016

Commits on Nov 18, 2016

  1. Don't reset non-dynamic settings unless explicitly requested 

    AbstractScopedSettings has the ability to only apply updates/deletes
to dynamic settings. The flag is currently not respected when a setting
is reset/deleted which causes static node settings to be reset if a non-dynamic
key is reset via `null` value.

Closes elastic#21593
    @s1monw
    s1monw committed Nov 18, 2016
    Configuration menu
    Copy the full SHA
    89a673f View commit details
    Browse the repository at this point in the history

  2. fix reset of wildcards

    @s1monw
    s1monw committed Nov 18, 2016
    Configuration menu
    Copy the full SHA
    c447d83 View commit details
    Browse the repository at this point in the history

  3. fix rests also for archived settings

    @s1monw
    s1monw committed Nov 18, 2016
    Configuration menu
    Copy the full SHA
    9a22ad7 View commit details
    Browse the repository at this point in the history

  4. add comment why we double check if we can remove

    @s1monw
    s1monw committed Nov 18, 2016
    Configuration menu
    Copy the full SHA
    d17ba06 View commit details
    Browse the repository at this point in the history