Makes allocator decision classes top-level classes #21662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
into their own top-level class, in order to use more easily in the allocation explain API. This commit also renames some of those decision related classes to more suitable names. This is simply a cosmetic change - no functionality changes with this commit whatsoever.
abeyad
changed the title
|
thanks @ywelsch |
abeyad
pushed a commit
that referenced
this pull request
Nov 18, 2016
This commit moves several allocation decider related inner classes into their own top-level class, in order to use more easily in the allocation explain API. This commit also renames some of those decision related classes to more suitable names. This is simply a cosmetic change - no functionality changes with this commit whatsoever. To summarize the changes: 1. ShardAllocationDecision renamed to AllocateUnassignedDecision 2. RelocationDecision moved to a top-level class 3. MoveDecision moved to a top-level class 4. RebalanceDecision moved to a top-level class 5. ShardAllocationDecisionTests renamed to AllocateUnassignedDecisionTests 6. NodeRebalanceResult moved to a top-level class 7. ShardAllocationDecision#WeightedDecision moved to a top-level class and renamed to NodeAllocationResult.
|
5.x commit: e086ca1 |
abeyad
pushed a commit
to abeyad/elasticsearch
that referenced
this pull request
Dec 3, 2016
them to be used directly by the cluster allocation explain API. In
particular, this commit does the following:
1. Adds serialization and toXContent methods to the response objects,
which will form the explain API responses.
2. Moves the calculation of the final explanation to the response
object itself, removing it from the responsibility of the
allocators.
3. Adds shard store information to the NodeAllocationResult, so that
store information is available for each node, when explaining a
shard allocation by the PrimaryShardAllocator or the
ReplicaShardAllocator.
4. Moves NodeRebalanceResult to its own top-level class, as that
was forgotten to be done in elastic#21662.
5. Adds delta information to the NodeRebalanceResult.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves several allocation decider related inner classes
into their own top-level class, in order to use more easily in
the allocation explain API. This commit also renames some of those
decision related classes to more suitable names.
This is simply a cosmetic change - no functionality changes with this
commit whatsoever.
To summarize the changes:
ShardAllocationDecisionrenamed toAllocateUnassignedDecisionRelocationDecisionmoved to a top-level classMoveDecisionmoved to a top-level classRebalanceDecisionmoved to a top-level classShardAllocationDecisionTestsrenamed toAllocateUnassignedDecisionTestsNodeRebalanceResultmoved to a top-level classShardAllocationDecision#WeightedDecisionmoved to a top-level class and renamed toNodeAllocationResult.