Remove indices query #21837
Merged
Remove indices query #21837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanna
added
:Search/Search
|
Although we said that this query can be removed in 6.0 as it was deprecated with 5.0, this change breaks backwards compatibility on the network layer. @s1monw what is our plan on changes like this? Can we just state that a search using this query will not work anymore against a mixed version cluster? Or do we want to somehow try and build a bw comp layer around this? |
|
@javanna I think we can't support stuff that is added in that fashion either. I think if you want to use 6 you have to stop using deprecated features before you do so. |
|
sounds good @s1monw thanks. |
|
@elasticmachine retest this please |
|
@jpountz would you mind reviewing this? |
jpountz
approved these changes
Nov 30, 2016
| @@ -10,6 +10,7 @@ | |||
| only the strings `"true"` and `"false"` will be parsed into their boolean | |||
| counterparts. Other strings will cause an error to be thrown. | |||
|
|
|||
| * The deprecated indices query has been removed. | |||
javanna
force-pushed
the
enhancement/remove_indices_query
branch
from
28eff56
to
b72c15f
Compare
The indices query is deprecated since 5.0.0 (elastic#17710). It can now be removed in master (future 6.0 version).
javanna
force-pushed
the
enhancement/remove_indices_query
branch
from
b72c15f
to
52cca3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The indices query is deprecated since 5.0.0 (#17710). It can now be removed in master (future 6.0 version).