New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove indices query #21837

Merged
merged 4 commits into from Nov 30, 2016

Conversation

Projects
None yet
3 participants
@javanna
Member

javanna commented Nov 28, 2016

The indices query is deprecated since 5.0.0 (#17710). It can now be removed in master (future 6.0 version).

@javanna

This comment has been minimized.

Show comment
Hide comment
@javanna

javanna Nov 28, 2016

Member

Although we said that this query can be removed in 6.0 as it was deprecated with 5.0, this change breaks backwards compatibility on the network layer. @s1monw what is our plan on changes like this? Can we just state that a search using this query will not work anymore against a mixed version cluster? Or do we want to somehow try and build a bw comp layer around this?

Member

javanna commented Nov 28, 2016

Although we said that this query can be removed in 6.0 as it was deprecated with 5.0, this change breaks backwards compatibility on the network layer. @s1monw what is our plan on changes like this? Can we just state that a search using this query will not work anymore against a mixed version cluster? Or do we want to somehow try and build a bw comp layer around this?

@javanna javanna added the review label Nov 28, 2016

@s1monw

This comment has been minimized.

Show comment
Hide comment
@s1monw

s1monw Nov 29, 2016

Contributor

@javanna I think we can't support stuff that is added in that fashion either. I think if you want to use 6 you have to stop using deprecated features before you do so.

Contributor

s1monw commented Nov 29, 2016

@javanna I think we can't support stuff that is added in that fashion either. I think if you want to use 6 you have to stop using deprecated features before you do so.

@javanna

This comment has been minimized.

Show comment
Hide comment
@javanna

javanna Nov 29, 2016

Member

sounds good @s1monw thanks.

Member

javanna commented Nov 29, 2016

sounds good @s1monw thanks.

@javanna

This comment has been minimized.

Show comment
Hide comment
@javanna

javanna Nov 29, 2016

Member

@elasticmachine retest this please

Member

javanna commented Nov 29, 2016

@elasticmachine retest this please

@javanna

This comment has been minimized.

Show comment
Hide comment
@javanna

javanna Nov 29, 2016

Member

@jpountz would you mind reviewing this?

Member

javanna commented Nov 29, 2016

@jpountz would you mind reviewing this?

@jpountz

LGTM

Show outdated Hide outdated docs/reference/migration/migrate_6_0/search.asciidoc
@@ -10,6 +10,7 @@
only the strings `"true"` and `"false"` will be parsed into their boolean
counterparts. Other strings will cause an error to be thrown.
* The deprecated indices query has been removed.

This comment has been minimized.

@jpountz

jpountz Nov 30, 2016

Contributor

s/indices/indices/?

@jpountz

jpountz Nov 30, 2016

Contributor

s/indices/indices/?

javanna added some commits Nov 28, 2016

Remove indices query
The indices query is deprecated since 5.0.0 (#17710). It can now be removed in master (future 6.0 version).

@javanna javanna merged commit 103984a into elastic:master Nov 30, 2016

1 of 2 checks passed

elasticsearch-ci Build finished.
Details
CLA Commit author is a member of Elasticsearch
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment