Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fromXContent method to GetResponse #22082

Merged
merged 18 commits into from Dec 19, 2016
Merged

Add fromXContent method to GetResponse #22082

merged 18 commits into from Dec 19, 2016

Commits on Dec 14, 2016

  1. Add fromXContent method to GetResponse 

    Moved field values toXContent logic to GetField (from GetResult), which outputs its own fields, and can also parse them now. Also added fromXContent to GetResult and GetResponse.

 The start object and end object for the get response output have been moved to GetResult#toXContent, from the corresponding rest action. This makes it possible to have toXContent and fromXContent completely symmetric, as parsing requires looping till an end object is found which is weird when the corresponding toXContent doesn't print that out.
    @javanna
    javanna committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    086e3e9 View commit details
    Browse the repository at this point in the history

  2. replace assertions with ParsingExceptions

    @javanna
    javanna committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    d3cb7cb View commit details
    Browse the repository at this point in the history

  3. fix MultiGetResponse output to not wrap GetResult into a new object

    @javanna
    javanna committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    8815682 View commit details
    Browse the repository at this point in the history

  4. addressed comments

    @javanna
    javanna committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    99f41fe View commit details
    Browse the repository at this point in the history

  5. split tests in three different classes that depend on each other 

    Also handled flat issue with SMILE and documented stuff
    @javanna
    javanna committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    5036ec8 View commit details
    Browse the repository at this point in the history

  6. last test improvements

    @javanna
    javanna committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    64c37d9 View commit details
    Browse the repository at this point in the history

  7. unified error messages from XContentParserUtils 

    Also refactored a bit the static methods exposed by XContentParserUtils
    @javanna
    javanna committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    6424cbb View commit details
    Browse the repository at this point in the history

  8. Remove unused method from XContentParserUtils

    @javanna
    javanna committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    4b570ce View commit details
    Browse the repository at this point in the history

  9. rename test method

    @javanna
    javanna committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    a7a0d5b View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2016

  1. addressed comments

    @javanna
    javanna committed Dec 15, 2016
    Configuration menu
    Copy the full SHA
    dbe320a View commit details
    Browse the repository at this point in the history

  2. simplify random source generation

    @javanna
    javanna committed Dec 15, 2016
    Configuration menu
    Copy the full SHA
    5361c1c View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2016

  1. modified parser creation orders in assertEquivalent

    @javanna
    javanna committed Dec 16, 2016
    Configuration menu
    Copy the full SHA
    34d2a5c View commit details
    Browse the repository at this point in the history

  2. rename RandomObjectPicks to RandomObjects

    @javanna
    javanna committed Dec 16, 2016
    Configuration menu
    Copy the full SHA
    14cdd53 View commit details
    Browse the repository at this point in the history

  3. check that the _source stays unchanged

    @javanna
    javanna committed Dec 16, 2016
    Configuration menu
    Copy the full SHA
    205933e View commit details
    Browse the repository at this point in the history

  4. clarify comment

    @javanna
    javanna committed Dec 16, 2016
    Configuration menu
    Copy the full SHA
    627b326 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2016

  1. support binary stored field values

    @javanna
    javanna committed Dec 19, 2016
    Configuration menu
    Copy the full SHA
    1fca7f8 View commit details
    Browse the repository at this point in the history

  2. fix test bug

    @javanna
    javanna committed Dec 19, 2016
    Configuration menu
    Copy the full SHA
    c74fd5b View commit details
    Browse the repository at this point in the history

  3. fix base64 comparisons

    @javanna
    javanna committed Dec 19, 2016
    Configuration menu
    Copy the full SHA
    d4a47d1 View commit details
    Browse the repository at this point in the history