Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase visibility of doExecute so it can be used directly #22614

Merged
merged 1 commit into from Jan 13, 2017

Conversation

polyfractal
Copy link
Contributor

Minor tweak to raise the visibility of doExecute(), so that other modules/plugins/libraries depending on Reindex can use it. The alternative is to make AsyncDeleteBySearchAction and ParentBulkByScrollTask public so they can be used directly, but it seemed cleaner to just elevate doExecute() instead so the user doesn't need to fiddle with the internal bits.

/cc @nik9000

Copy link
Contributor

@s1monw s1monw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polyfractal polyfractal merged commit 18fdc39 into elastic:master Jan 13, 2017
@lcawl lcawl added :Distributed/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. and removed :Reindex API labels Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >enhancement v5.3.0 v6.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants