New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase visibility of doExecute so it can be used directly #22614

Merged
merged 1 commit into from Jan 13, 2017

Conversation

Projects
None yet
4 participants
@polyfractal
Member

polyfractal commented Jan 13, 2017

Minor tweak to raise the visibility of doExecute(), so that other modules/plugins/libraries depending on Reindex can use it. The alternative is to make AsyncDeleteBySearchAction and ParentBulkByScrollTask public so they can be used directly, but it seemed cleaner to just elevate doExecute() instead so the user doesn't need to fiddle with the internal bits.

/cc @nik9000

@s1monw

s1monw approved these changes Jan 13, 2017

LGTM

@polyfractal polyfractal merged commit 18fdc39 into elastic:master Jan 13, 2017

1 of 2 checks passed

elasticsearch-ci Build triggered. sha1 is merged.
Details
CLA Commit author is a member of Elasticsearch
Details

@polyfractal polyfractal added v6.0.0-alpha1 and removed review labels Jan 13, 2017

polyfractal added a commit that referenced this pull request Jan 13, 2017

@polyfractal polyfractal added the v5.3.0 label Jan 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment