New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove blocking TCP clients and servers #22639
Conversation
This commit removes the option to use the blocking variants of the TCP transport server, TCP transport client, or http server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good. I think that we need a note in the migration docs in this pull request, and then deprecation logging in the 5.x branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ thanks
@jasontedor I added a migration doc. Let me know if that looks alright. |
|
||
==== Network settings | ||
|
||
The blocking tcp client, blocking tcp server, and blocking http server have been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: tcp
-> TCP
, http
-> HTTP
Just a nit, I'm good with you merging it after you make the change. |
This commit removes the option to use the blocking variants of the TCP
transport server, TCP transport client, or http server.