Handle BlobPath's trailing separator case. Add test cases to BlobPathTests.java #23091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Any updates on this pull request? Anything I need to change or update? |
|
@tlrx could you review this please? |
tlrx
approved these changes
Feb 22, 2017
There was a problem hiding this comment.
Thank for your contribution @mms-programming ! The kind of small bugs that are really annoying... And sorry for the time it took me to review your fix.
tlrx
pushed a commit
that referenced
this pull request
Feb 22, 2017
(cherry picked from commit d31e415)
|
@tlrx happy to contribute! |
clintongormley
added
:Distributed/Snapshot/Restore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a trailing / is present at the end of base_path in s3 repository creation, an extra slash still gets prepended and this causes S3 to create an empty folder. This was not a problem in our ES 2.4 cluster as we always included the / at the end and was dealt with here:
https://github.com/elastic/elasticsearch/blob/v2.4.4/plugins/cloud-aws/src/main/java/org/elasticsearch/repositories/s3/S3Repository.java#L140-L146.
Specifically, the splitStringToArray on L142 got rid of the trailing slashes.
This pull request fixes the trailing / issue. It also adds extra test case to BlobPathTests.java.