Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve missing ingest processor error #23379

Conversation

martijnvg
Copy link
Member

@martijnvg martijnvg commented Feb 27, 2017

This pr fixes two issues:

  • Accumulate any potential other processor parse errors before failing instead of failing upon first processor parsing error. This is useful if more than one processor type is unknown, so that the client creating the pipeline knows about all missing processors. Note that suppressed exceptions are not rendered yet on the rest layer. However suppressed exceptions are being serialized in the internal node-to-node layer.
  • Attach type and tag header to the error that is thrown when ingest processor isn't available on other ingest nodes.

@martijnvg martijnvg added :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >bug review v5.4.0 v6.0.0-alpha1 labels Feb 27, 2017
@martijnvg martijnvg force-pushed the ingest_better_missing_processor_type_error branch from 3f0f418 to 1256b78 Compare February 28, 2017 10:45
Copy link
Contributor

@talevy talevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…type isn't available on node.

[INGEST] Accumulate any potential other processor parse errors before failing instead of failing upon first processor parsing error.
@martijnvg martijnvg force-pushed the ingest_better_missing_processor_type_error branch from 1256b78 to 1d3f6c4 Compare March 2, 2017 08:08
@martijnvg martijnvg merged commit 1d3f6c4 into elastic:master Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v5.3.0 v5.4.0 v6.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants