-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start on custom whitelists for Painless #23563
Merged
Merged
Commits on Mar 13, 2017
-
Painless: Start on custom whitelists
We'd like to be able to support context-sensitive whitelists in Painless but we can't now because the whitelist is a static thing. This begins to de-static the whitelist, in particular removing the static keyword from `Definition#getRuntimeClass` and plumbing the static instance into the appropriate spots as though it weren't static. Once we de-static all the methods we should be able to fairly simply build context-sensitive whitelists. The only "fun" bit of this is that I added another layer in the chain of methods that bootstraps `def` calls. Instead of running `invokedynamic` directly on `DefBootstrap` we now `invokedynamic` `$bootstrapDef` on the script itself loads the `Definition` that the script was compiled against and then calls `DefBootstrap`.
Configuration menu - View commit details
-
Copy full SHA for cd70cd8 - Browse repository at this point
Copy the full SHA cd70cd8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 12c175d - Browse repository at this point
Copy the full SHA 12c175dView commit details
Commits on Mar 23, 2017
-
Configuration menu - View commit details
-
Copy full SHA for f28fa03 - Browse repository at this point
Copy the full SHA f28fa03View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcd7bd4 - Browse repository at this point
Copy the full SHA dcd7bd4View commit details -
I chose to put `Definition` into `Locals` so I didn't have to change the signature of all the `analyze` methods. I could have do it another way, but that seems ok for now.
Configuration menu - View commit details
-
Copy full SHA for 1746e41 - Browse repository at this point
Copy the full SHA 1746e41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d889f5 - Browse repository at this point
Copy the full SHA 0d889f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 161a62c - Browse repository at this point
Copy the full SHA 161a62cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e98b24 - Browse repository at this point
Copy the full SHA 7e98b24View commit details -
Configuration menu - View commit details
-
Copy full SHA for 200ba16 - Browse repository at this point
Copy the full SHA 200ba16View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.