-
Notifications
You must be signed in to change notification settings - Fork 24.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Specify that byte units use powers of 1024 #23574
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
In SI units, "kilobyte" or "kB" would mean 1000 bytes, whereas "KiB" is used for 1024. Add a note in `api-conventions.asciidoc` to clarify the meaning in Elasticsearch.
We signed the CLA already some time ago, did something change with it? Anyway, I signed it again now. Not sure if the check needs to be triggered again, or if it just needs some time to process. |
Commenting triggered it. Usually when you make a PR and it isn't recognized it is because some email doesn't line up somewhere. Either way, you've got it now. Change looks good. I'll merge it and backport. |
In SI units, "kilobyte" or "kB" would mean 1000 bytes, whereas "KiB" is used for 1024. Add a note in `api-conventions.asciidoc` to clarify the meaning in Elasticsearch.
In SI units, "kilobyte" or "kB" would mean 1000 bytes, whereas "KiB" is used for 1024. Add a note in `api-conventions.asciidoc` to clarify the meaning in Elasticsearch.
In SI units, "kilobyte" or "kB" would mean 1000 bytes, whereas "KiB" is used for 1024. Add a note in `api-conventions.asciidoc` to clarify the meaning in Elasticsearch.
All backported! Thanks again @robinst! |
Thanks for backporting! :) |
* master: Clear the interrupt flag before joining Migrate to max line length of 100 Docs: Corrected path to elasticsearch-plugin (elastic#23622) Docs: Add comma to reverse nested agg snippet Fix third-party audit task for Gradle 3.4 (elastic#23612) Adapter action future should restore interrupts Update scripting.asciidoc Unmark reindex as experimental CompletionSuggestionContext#toQuery() should also consider text if prefix/regex missing (elastic#23451) Docs: Specify that byte units use powers of 1024 (elastic#23574) Remove Settings.settingsBuilder (elastic#23575) Change params._source to params['_source'] in example. Fix example in documentation for Painless using _source. (elastic#21322) Remove extra line from license header Fix num docs to be positive in bucket deferring collector test Mapping: Fix NPE with scaled floats stats when field is not indexed (elastic#23528)
* single-node-discovery: Clear the interrupt flag before joining Migrate to max line length of 100 Docs: Corrected path to elasticsearch-plugin (elastic#23622) Docs: Add comma to reverse nested agg snippet Fix third-party audit task for Gradle 3.4 (elastic#23612) Adapter action future should restore interrupts Update scripting.asciidoc Unmark reindex as experimental CompletionSuggestionContext#toQuery() should also consider text if prefix/regex missing (elastic#23451) Docs: Specify that byte units use powers of 1024 (elastic#23574) Remove Settings.settingsBuilder (elastic#23575) Change params._source to params['_source'] in example. Fix example in documentation for Painless using _source. (elastic#21322) Remove extra line from license header Fix num docs to be positive in bucket deferring collector test Mapping: Fix NPE with scaled floats stats when field is not indexed (elastic#23528)
* master: Clear the interrupt flag before joining Migrate to max line length of 100 Docs: Corrected path to elasticsearch-plugin (elastic#23622) Docs: Add comma to reverse nested agg snippet Fix third-party audit task for Gradle 3.4 (elastic#23612) Adapter action future should restore interrupts Update scripting.asciidoc Unmark reindex as experimental CompletionSuggestionContext#toQuery() should also consider text if prefix/regex missing (elastic#23451) Docs: Specify that byte units use powers of 1024 (elastic#23574) Remove Settings.settingsBuilder (elastic#23575)
In SI units, "kilobyte" or "kB" would mean 1000 bytes, whereas "KiB" is
used for 1024. Add a note in
api-conventions.asciidoc
to clarify themeaning in Elasticsearch.