Adapter action future should restore interrupts #23618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasontedor
added
:Core/Infra/Core
When a thread blocking on an adapter action future is interrupted, we throw an illegal state exception. This is documented, but it is rude to not restore the interrupt flag. This commit restores the interrupt flag in this situation, and adds a test.
jasontedor
force-pushed
the
interrupting-is-rude
branch
from
a779d4a
to
58302c5
Compare
nik9000
approved these changes
Mar 16, 2017
jasontedor
added a commit
that referenced
this pull request
Mar 17, 2017
When a thread blocking on an adapter action future is interrupted, we throw an illegal state exception. This is documented, but it is rude to not restore the interrupt flag. This commit restores the interrupt flag in this situation, and adds a test. Relates #23618
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a thread blocking on an adapter action future is interrupted, we throw an illegal state exception. This is documented, but it is rude to not restore the interrupt flag. This commit restores the interrupt flag in this situation, and adds a test.
Closes #23617