Switch include_in_all in multifield to warning #23656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts elastic#21971 which should only have been applied in master to preserve backwards compatibility. Instead of throwing an error when you specify `include_in_all` inside a multifield we instead return a deprecation warning. `include_in_all` in a multifield still doesn't do anything. But at least people who use it erroneously won't break. Closes elastic#23654
nik9000
added
:Search/Mapping
|
I'm running the full test suite against this now but I figured it was worth opening quickly. This doesn't make |
|
Note that this PR is against the 5.x branch only and we'll backport all the way to the 5.2 branch. |
Thanks! |
|
Thanks @jasontedor! Backported! |
nik9000
added a commit
that referenced
this pull request
Mar 20, 2017
This reverts #21971 which should only have been applied in master to preserve backwards compatibility. Instead of throwing an error when you specify `include_in_all` inside a multifield we instead return a deprecation warning. `include_in_all` in a multifield still doesn't do anything. But at least people who use it erroneously won't break. Closes #23654
nik9000
added a commit
that referenced
this pull request
Mar 20, 2017
This reverts #21971 which should only have been applied in master to preserve backwards compatibility. Instead of throwing an error when you specify `include_in_all` inside a multifield we instead return a deprecation warning. `include_in_all` in a multifield still doesn't do anything. But at least people who use it erroneously won't break. Closes #23654
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #21971 which should only have been applied in master
to preserve backwards compatibility. Instead of throwing an error
when you specify
include_in_allinside a multifield we insteadreturn a deprecation warning.
include_in_allin a multifieldstill doesn't do anything. But at least people who use it erroneously
won't break.
Closes #23654