Add early-access check #23743
Merged
Add early-access check #23743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OpenJDK project provides early-access builds of upcoming releases. These early-access builds are not suitable for production. These builds sometimes end up on systems due to aggressive packaging (e.g., Ubuntu). This commit adds a bootstrap check to ensure these early-access builds are not being used in production.
jasontedor
added
:Core/Infra/Core
abeyad
approved these changes
Mar 24, 2017
| return javaVersion.endsWith("-ea"); | ||
| } else { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Nit: return "Oracle Corporation".equals(jvmVendor()) && javaVersion().endsWith("-ea") more succinct?
| @@ -560,12 +560,48 @@ private void runMightForkTest( | |||
| consumer.accept(e); | |||
| } | |||
|
|
|||
| public void testEarlyAccessCheck() throws NodeValidationException { | |||
| final AtomicReference<String> javaVersion | |||
| = new AtomicReference<>(randomFrom("1.8.0_152-ea", "9-ea")); | |||
There was a problem hiding this comment.
Why does this need to be an AtomicReference?
There was a problem hiding this comment.
Because I set it to a different value further down in the method to simulate a check where the Java version is not an early-access build.
There was a problem hiding this comment.
++, i didn't realize it was just one instance of the EarlyAccessCheck
jasontedor
added a commit
that referenced
this pull request
Mar 24, 2017
The OpenJDK project provides early-access builds of upcoming releases. These early-access builds are not suitable for production. These builds sometimes end up on systems due to aggressive packaging (e.g., Ubuntu). This commit adds a bootstrap check to ensure these early-access builds are not being used in production. Relates #23743
|
Thanks @abeyad. |
sudo-suhas
pushed a commit
to sudo-suhas/elasticsearch
that referenced
this pull request
Mar 27, 2017
The OpenJDK project provides early-access builds of upcoming releases. These early-access builds are not suitable for production. These builds sometimes end up on systems due to aggressive packaging (e.g., Ubuntu). This commit adds a bootstrap check to ensure these early-access builds are not being used in production. Relates elastic#23743
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Jun 10, 2017
The OpenJDK project provides early-access builds of upcoming releases. These early-access builds are not suitable for production. These builds sometimes end up on systems due to aggressive packaging (e.g., Ubuntu). This commit adds a bootstrap check to ensure these early-access builds are not being used in production. Relates elastic#23743
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenJDK project provides early-access builds of upcoming releases. These early-access builds are not suitable for production. These builds sometimes end up on systems due to aggressive packaging (e.g., Ubuntu). This commit adds a bootstrap check to ensure these early-access builds are not being used in production.
Relates #23668