Replace NestedChildrenQuery with ParentChildrenBlockJoinQuery #24016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should it be merged to 5.3.1? cc @clintongormley |
|
|
If we are ok with backporting this to 5.3 branch, then I'll make it in a different pr. |
martijnvg
force-pushed
the
inner_hits_use_ParentChildrenBlockJoinQuery
branch
from
3eea8e4
to
887f3ed
Compare
|
@martijnvg Can you update the description of this PR so that it better explains the bug it fixes?
+1 |
|
@jpountz updated the description. |
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #24009
Before this change if
NestedChildrenQuerywere to be cached it could lead to memory leak, because this query keeps a reference to the IndexReader. The chance that it would be cached is low, because this query is different for each search request and search hit it is trying to fetch inner hits for.