Deprecate Stats#getCountAsString #24292
Conversation
We don't render an "count_as_string" in the rest response, so the method should also be removed in favour of just using String.valueOf(getCount()) if a string version of the count is needed.
cbuescher
added
:Analytics/Aggregations
|
Why do we need to deprecate this? I think with java api changes we ask users to rely on their compilers. We made such changes already without deprecation in 5.x. |
|
I think its still ok for us to deprecate things where we have the chance to. The removal of this is happening in 6.0 so I think its good to deprecate it in 5.x even if its not required |
|
@colings86 thanks, will merge this to 5.x. I also agree that its better to add a deprecation note if it is possible, especially since this is a user facing interface. |
|
Not a huge deal but I don't see why we have to go case by case. As much as I may not like it, the policy is that we deprecate things on the REST layer, and java API users rely on their compiler. If we use deprecation for this we should do it across the board which we don't. It makes little sense to do it here then. |
We don't render an "count_as_string" in the rest response, so the method should also be removed in favour of just using String.valueOf(getCount()) if a string version of the count is needed.
We don't render an "count_as_string" in the rest response,
so the method should also be removed in favour of just using
String.valueOf(getCount()) if a string version of the count is needed.