Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change snapshot status error to use generic SnapshotException #24355

Merged
merged 1 commit into from
Apr 27, 2017

Conversation

abeyad
Copy link

@abeyad abeyad commented Apr 27, 2017

Changes the snapshot status read exception from the (misleading)
IndexShardRestoreFailedException to the generic SnapshotException

Closes #24225

IndexShardRestoreFailedException to the generic SnapshotException

Closes elastic#24225
@abeyad abeyad added :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >enhancement v5.4.0 v5.5.0 v6.0.0-alpha1 labels Apr 27, 2017
@abeyad abeyad requested a review from imotov April 27, 2017 03:16
Copy link
Contributor

@imotov imotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this one confused me as well when I was looking at the stack trace the other day. Thanks for taking care of it! LGTM.

@abeyad abeyad merged commit 2facc42 into elastic:master Apr 27, 2017
@abeyad
Copy link
Author

abeyad commented Apr 27, 2017

thanks @imotov!

abeyad pushed a commit that referenced this pull request Apr 27, 2017
Changes the snapshot status read exception from the (misleading)
IndexShardRestoreFailedException to the generic SnapshotException

Closes #24225
abeyad pushed a commit that referenced this pull request Apr 27, 2017
Changes the snapshot status read exception from the (misleading)
IndexShardRestoreFailedException to the generic SnapshotException

Closes #24225
@abeyad abeyad deleted the change_status_read_exception branch April 27, 2017 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants