Add new ip_range field type #24433
Closed
Add new ip_range field type #24433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nknize
added
:Search/Mapping
jpountz
requested changes
May 3, 2017
| } | ||
| @Override | ||
| public InetAddress parseFrom(RangeFieldType fieldType, XContentParser parser, boolean coerce, boolean included) | ||
| throws IOException { |
There was a problem hiding this comment.
can you indent so that the throws is not indented at the same level as the content of the block? (similar issues on the below lines)
| @Override | ||
| public InetAddress parse(Object value, boolean coerce) { | ||
| try { | ||
| return value instanceof InetAddress ? (InetAddress) value : InetAddress.getByName((String) value); |
There was a problem hiding this comment.
can you use InetAddresses.forString intead, which guarantees it won't do a dns lookup
| if (type.equals("date_range")) { | ||
| strVal = "1477872000000"; | ||
| } else if (type.equals("ip_range")) { | ||
| strVal = "/192.168.1.7:/2001:db8:0:0:0:0:0:0"; |
There was a problem hiding this comment.
I guess we get this by doing a toString on an InetAddress. Could you make sure we use InetAddresses.toAddrString instead?
nknize
force-pushed
the
InetAddressRangeField
branch
from
0ac5481
to
48c83b2
Compare
|
Thanks for the excellent feedback @jpountz. I made the changes and will go ahead and merge tomorrow unless you have any other concerns. |
jpountz
approved these changes
May 4, 2017
nknize
force-pushed
the
InetAddressRangeField
branch
from
a3279a9
to
66e5878
Compare
This commit adds support for indexing and searching a new ip_range field type. Both IPv4 and IPv6 formats are supported. Tests are updated and docs are added.
nknize
force-pushed
the
InetAddressRangeField
branch
from
78c1a65
to
549070b
Compare
|
merged in 0c4eb0a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for indexing and searching the new
ip_rangefield type. Both IPv4 and IPv6 formats are supported. Tests and docs are updated.