Move AggregatorTestCase to test framework #24594
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows plugins to use the test class. Only potentially controversial point is that `build()` had to be made public instead of protected... but the sole user of that API (AbstractAggregatorBuilder) already exposed it as public so I think this is ok.
polyfractal
added
:Analytics/Aggregations
|
@polyfractal this test base class has been moved to test framework module via #24638, so I think we can close this one? |
|
👍 That's what I get for sending a PR and then going on holiday :) Closing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows plugins to use the test class. The only material, and potentially controversial, change is that
build()had to be made public instead of protected... but the sole user of that API(
AbstractAggregatorBuilder) already exposed it as public so I think this is ok.Everything else is just automated formatting and some unused import cleanup.
/cc @colings86 @martijnvg