Add the ability to define custom inner hit sub context builder #24676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
reviewed
May 19, 2017
There was a problem hiding this comment.
Looks good!
Would be great to have bwc serialization tests in NestedQueryBuilderTests, HasChildQueryBuilderTests and HasParentQueryBuilderTests. Right now these tests do test serialization, but only with the current version. We should also test that these query builders parse 5.x serialization format correctly.
| } | ||
|
|
||
| private String name; | ||
| private String nestedPath; |
There was a problem hiding this comment.
Thanks for moving this to InnerHitContextBuilder and its subclasses!
|
Thanks @martijnvg |
jimczi
force-pushed
the
inner_hits_refactoring
branch
from
c5331ea
to
f17c2f6
Compare
jimczi
force-pushed
the
inner_hits_refactoring
branch
from
f17c2f6
to
f6d587f
Compare
This commit moves the handling of nested and parent/child inner hits to specialized classes that can be defined outside of ES core. InnerHitBuilderContext is now used by the parent query (nested or hasChild, ...) to build the sub context from the InnerHitBuilder definition. BWC is also ensured so that nodes in previous versions can still send/receive inner hits to/from this version.` Relates elastic#20257
jimczi
force-pushed
the
inner_hits_refactoring
branch
from
601c9d6
to
d0ecc76
Compare
jimczi
added a commit
that referenced
this pull request
May 23, 2017
This commit moves the handling of nested and parent/child inner hits to specialized classes that can be defined outside of ES core. InnerHitBuilderContext is now used by the parent query (nested or hasChild, ...) to build the sub context from the InnerHitBuilder definition. BWC is also ensured so that nodes in previous versions can still send/receive inner hits to/from this version. Relates #20257
jimczi
added a commit
that referenced
this pull request
May 23, 2017
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves the handling of nested and parent/child inner hits to specialized classes that can be defined outside of ES core.
InnerHitBuilderContext is now used by the parent query (nested or hasChild, ...) to build the sub context from the InnerHitBuilder definition.
BWC is also ensured so that nodes in previous versions can still send/receive inner hits to/from this version.`
Relates #20257