Remove Deprecated Script Settings #24756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
:Core/Infra/Scripting
jdconrad
changed the title
rjernst
approved these changes
May 17, 2017
| import java.util.Set; | ||
| import java.util.function.Function; | ||
|
|
||
| public class ScriptSecurity { |
There was a problem hiding this comment.
I don't like this name, this isn't really about security, it is just a feature of scripting in ES to disable certain contexts/types. And I think this is small enough it could just be part of ScriptService which is the only place it is used?
| } | ||
| } | ||
|
|
||
| if (!found) { |
|
@elasticmachine please test this |
1 similar comment
|
@elasticmachine please test this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all fine grained settings for script types, contexts, and engines.
Script settings will now be specified as defined in #24532.