Remove mapping.single_type from parent join test
#25391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the remaining usage of `mapping.single_type` from the parent join module and moves it's bwc test to the mixed cluster tests Relates to elastic#24961
s1monw
added
>non-issue
review
>test
|
Lgtm
…On Sun, Jun 25, 2017, 12:15 PM Simon Willnauer ***@***.***> wrote:
@s1monw <https://github.com/s1monw> requested your review on:
elastic/elasticsearch#25391
<#25391> Remove
mapping.single_type from parent join test.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25391 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANLomDeim0fSzAewn6z8eUVgsOV6xI4ks5sHoeOgaJpZM4OEphD>
.
|
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jun 26, 2017
* master: Throw useful error on bad docs snippets (elastic#25389) Remove `mapping.single_type` from parent join test (elastic#25391) Tests: Fix array out of bounds exception in TemplateUpgradeServiceIT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the remaining usage of
mapping.single_typefrom the parent joinmodule and moves it's bwc test to the mixed cluster tests
Relates to #24961
Relates to #20257