Loosen the restrictions on disabling _all in 6.x #26259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With 6.0+ we previously threw an exception when the `_all` field was configured at all. This loosens that restriction a little bit so that the error is only thrown when `_all` is enabled. A deprecation warning is returned/logged instead if any `_all` configuration is found. In 7.0, we retain the behavior of throwing an exception if `_all` is enabled at all.
dakrone
added
:Search/Mapping
jpountz
approved these changes
Aug 17, 2017
|
Thanks @jpountz! |
dakrone
added a commit
that referenced
this pull request
Aug 17, 2017
With 6.0+ we previously threw an exception when the `_all` field was configured at all. This loosens that restriction a little bit so that the error is only thrown when `_all` is enabled. A deprecation warning is returned/logged instead if any `_all` configuration is found. In 7.0, we retain the behavior of throwing an exception if `_all` is enabled at all.
colings86
added
6.0.0-beta2
v6.0.0-beta2
>enhancement
and removed
v6.0.0
6.0.0-beta2
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With 6.0+ we previously threw an exception when the
_allfield was configuredat all. This loosens that restriction a little bit so that the error is only
thrown when
_allis enabled. A deprecation warning is returned/logged insteadif any
_allconfiguration is found.In 7.0, we retain the behavior of throwing an exception if
_allis enabled atall.