Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen the restrictions on disabling _all in 6.x #26259

Merged
merged 1 commit into from Aug 17, 2017

Conversation

Projects
None yet
4 participants
@dakrone
Copy link
Member

commented Aug 17, 2017

With 6.0+ we previously threw an exception when the _all field was configured
at all. This loosens that restriction a little bit so that the error is only
thrown when _all is enabled. A deprecation warning is returned/logged instead
if any _all configuration is found.

In 7.0, we retain the behavior of throwing an exception if _all is enabled at
all.

Loosen the restrictions on disabling _all in 6.x
With 6.0+ we previously threw an exception when the `_all` field was configured
at all. This loosens that restriction a little bit so that the error is only
thrown when `_all` is enabled. A deprecation warning is returned/logged instead
if any `_all` configuration is found.

In 7.0, we retain the behavior of throwing an exception if `_all` is enabled at
all.

@dakrone dakrone merged commit 720f1b4 into elastic:6.x Aug 17, 2017

2 checks passed

CLA Commit author has signed the CLA
Details
elasticsearch-ci Build finished.
Details
@dakrone

This comment has been minimized.

Copy link
Member Author

commented Aug 17, 2017

Thanks @jpountz!

dakrone added a commit that referenced this pull request Aug 17, 2017

Loosen the restrictions on disabling _all in 6.x (#26259)
With 6.0+ we previously threw an exception when the `_all` field was configured
at all. This loosens that restriction a little bit so that the error is only
thrown when `_all` is enabled. A deprecation warning is returned/logged instead
if any `_all` configuration is found.

In 7.0, we retain the behavior of throwing an exception if `_all` is enabled at
all.

@lcawl lcawl removed the v6.1.0 label Dec 12, 2017

@dakrone dakrone deleted the dakrone:loosen-all-restrictions branch Dec 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.