Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in date format #26503

Merged
merged 2 commits into from
Sep 25, 2017
Merged

Fix typo in date format #26503

merged 2 commits into from
Sep 25, 2017

Conversation

liketic
Copy link
Contributor

@liketic liketic commented Sep 5, 2017

Fix #26500

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@jpountz
Copy link
Contributor

jpountz commented Sep 5, 2017

@liketic Thanks for the PR. Would you mind adding a test to avoid regressions in the future?

@jpountz jpountz added the :Dates label Sep 5, 2017
@jpountz jpountz self-requested a review September 5, 2017 08:24
@jpountz jpountz added the >bug label Sep 5, 2017
@jasontedor jasontedor mentioned this pull request Sep 5, 2017
Closed
jpountz
jpountz approved these changes Sep 7, 2017
View reviewed changes
Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me, I just left a minor comment about using expectThrows instead of try/fail/catch/assert for testing.

core/src/test/java/org/elasticsearch/common/joda/JodaTests.java Outdated
fail("Pattern: " + format);
} catch (IllegalArgumentException e) {
assertThat(e.getMessage().contains("Invalid format: [" + format + "]"), equalTo(true));
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use expectThrows instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks.

@jimczi jimczi mentioned this pull request Sep 14, 2017
Closed
@jpountz jpountz merged commit 8f5f634 into elastic:master Sep 25, 2017
jpountz pushed a commit that referenced this pull request Sep 25, 2017
@jpountz
Fix typo in date format (#26503)
32fb3f8
jpountz pushed a commit that referenced this pull request Sep 25, 2017
@jpountz
Fix typo in date format (#26503)
f7273e8
@liketic liketic deleted the buffix/issues/26500 branch October 26, 2017 02:48
@clintongormley clintongormley added :Search Foundations/Mapping Index mappings, including merging and defining field types and removed :Dates labels Feb 13, 2018
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpountz jpountz jpountz approved these changes

Assignees
No one assigned
Labels
>bug Pioneer Program :Search Foundations/Mapping Index mappings, including merging and defining field types v6.0.0-rc1 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@liketic @elasticmachine @jpountz @clintongormley @colings86 @jimczi