Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable adaptive replica selection by default #26522

Merged
merged 1 commit into from
Sep 7, 2017
Merged

Enable adaptive replica selection by default #26522

merged 1 commit into from
Sep 7, 2017

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Sep 6, 2017

Relates to #24915

This is only for 7.0 only, as this is a breaking change.

@dakrone dakrone added :Search/Search Search-related issues that do not fall into other categories >breaking v7.0.0 labels Sep 6, 2017
jpountz
jpountz approved these changes Sep 7, 2017
View reviewed changes
Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Should we remove the breaking label? I think it's worth noting so I'm +1 to put in in the migration guide in the docs like you did, but labelling it as breaking does not sound right to me?

@dakrone
Copy link
Member Author

dakrone commented Sep 7, 2017

Should we remove the breaking label?

Yeah probably a good idea, it's not like this breaks anything in response or anything, it's entirely internal.

Thanks for the review!

@dakrone dakrone removed the >breaking label Sep 7, 2017
@dakrone dakrone merged commit cff904b into elastic:master Sep 7, 2017
@dakrone dakrone deleted the enable-ars-by-default branch December 13, 2017 20:35
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpountz jpountz jpountz approved these changes

Assignees
No one assigned
Labels
>feature :Search/Search Search-related issues that do not fall into other categories v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dakrone @jpountz @jimczi