Early termination with index sorting should not set terminated_early in the response #26597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the response Early termination with index sorting always return the best top N in the response but set the flag `terminated_early` in the response. This can be confusing because we use the same flag for `terminate_after` which on the contrary returns partial results. This change removes the flag when results are not partial (early termination due to index sorting) and keeps it only when `terminate_after` is used. Closes elastic#26408
jimczi
added
:Search/Search
jimczi
added a commit
that referenced
this pull request
Sep 26, 2017
…in the response (#26597) Early termination with index sorting always return the best top N in the response but set the flag `terminated_early` in the response. This can be confusing because we use the same flag for `terminate_after` which on the contrary returns partial results. This change removes the flag when results are not partial (early termination due to index sorting) and keeps it only when `terminate_after` is used. Closes #26408
jimczi
added a commit
that referenced
this pull request
Oct 5, 2017
…in the response (#26597) Early termination with index sorting always return the best top N in the response but set the flag `terminated_early` in the response. This can be confusing because we use the same flag for `terminate_after` which on the contrary returns partial results. This change removes the flag when results are not partial (early termination due to index sorting) and keeps it only when `terminate_after` is used. Closes #26408
jimczi
added a commit
that referenced
this pull request
Oct 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Early termination with index sorting always return the best top N in the response but set the flag
terminated_earlyin the response. This can be confusing because we use the same flag forterminate_afterwhich on the contrary returns partial results.This change removes the flag when results are not partial (early termination due to index sorting) and keeps it only when
terminate_afteris used.Closes #26408