Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing script contexts and types allowed settings #26703

Merged
merged 1 commit into from Sep 19, 2017
Merged

Add missing script contexts and types allowed settings #26703

merged 1 commit into from Sep 19, 2017

Conversation

jdconrad
Copy link
Contributor

As the title says.

Relates to (#26651)

@jdconrad jdconrad added :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >bug v5.6.0 labels Sep 19, 2017
jasontedor
jasontedor approved these changes Sep 19, 2017
View reviewed changes
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jdconrad
Copy link
Contributor Author

@jasontedor Thanks for the review, will commit as soon as the CI passes just to be sure.

@jdconrad jdconrad merged commit fbfc6d8 into elastic:5.6 Sep 19, 2017
@rjernst rjernst mentioned this pull request Sep 19, 2017
Closed
@colings86 colings86 added v5.6.2 and removed v5.6.0 labels Sep 21, 2017
@jdconrad jdconrad deleted the setting56 branch October 30, 2017 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasontedor jasontedor jasontedor approved these changes

@rjernst rjernst Awaiting requested review from rjernst

Assignees
No one assigned
Labels
>bug :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache v5.6.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jdconrad @jasontedor @colings86