Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins: Add backcompat for sha1 checksums #26748

Merged
merged 2 commits into from
Sep 22, 2017

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Sep 22, 2017

With 6.0 rc1 we now publish sha512 checksums for official plugins.
However, in order to ease the pain for plugin authors, this commit adds
backcompat to still allow sha1 checksums. Also added tests for
checksums.

closes #26746

With 6.0 rc1 we now publish sha512 checksums for official plugins.
However, in order to ease the pain for plugin authors, this commit adds
backcompat to still allow sha1 checksums.  Also added tests for
checksums.

closes elastic#26746
@rjernst rjernst added >deprecation and removed >bug labels Sep 22, 2017
Copy link
Contributor

@s1monw s1monw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM awesome that we now have tests!!

@s1monw s1monw merged commit 5b711c2 into elastic:master Sep 22, 2017
@s1monw s1monw deleted the plugin_installer_sha branch September 22, 2017 09:26
s1monw pushed a commit that referenced this pull request Sep 22, 2017
With 6.0 rc1 we now publish sha512 checksums for official plugins.
However, in order to ease the pain for plugin authors, this commit adds
backcompat to still allow sha1 checksums.  Also added tests for
checksums.

Closes #26746
s1monw pushed a commit that referenced this pull request Sep 22, 2017
With 6.0 rc1 we now publish sha512 checksums for official plugins.
However, in order to ease the pain for plugin authors, this commit adds
backcompat to still allow sha1 checksums.  Also added tests for
checksums.

Closes #26746
jasontedor pushed a commit that referenced this pull request Sep 22, 2017
With 6.0 rc1 we now publish sha512 checksums for official plugins.
However, in order to ease the pain for plugin authors, this commit adds
backcompat to still allow sha1 checksums.  Also added tests for
checksums.

Closes #26746
@mgreau
Copy link
Member

mgreau commented Nov 8, 2017

@rjernst @jasontedor As far as I understand the code, we will print a warning message for the community plugins uploaded on Maven Central (Please update the plugin to use a sha512 checksum) but the authors can't do it until that Maven Central (Sonatype Nexus) supports it or generates those sha512 files. Should we do an exception (for the warning message) until Maven Central supports it?

@mgreau
Copy link
Member

mgreau commented Nov 8, 2017

@rjernst @jasontedor I have asked to Sonatype to remove the security level on the JIRA issue, they did it very quickly so you should be able to view it now. By the way, I had the confirmation that sha512 is not supported by Maven Central yet, by this person:

That's correct. We currently only publish md5 and sha1 checksums. I've started asking around here on the feasibility of generating and publishing sha512.

@lcawl lcawl removed the v6.1.0 label Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Online plugin Installation looks for sha1, we now only produce sha512
5 participants