-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugins: Add backcompat for sha1 checksums #26748
Conversation
With 6.0 rc1 we now publish sha512 checksums for official plugins. However, in order to ease the pain for plugin authors, this commit adds backcompat to still allow sha1 checksums. Also added tests for checksums. closes elastic#26746
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM awesome that we now have tests!!
With 6.0 rc1 we now publish sha512 checksums for official plugins. However, in order to ease the pain for plugin authors, this commit adds backcompat to still allow sha1 checksums. Also added tests for checksums. Closes #26746
With 6.0 rc1 we now publish sha512 checksums for official plugins. However, in order to ease the pain for plugin authors, this commit adds backcompat to still allow sha1 checksums. Also added tests for checksums. Closes #26746
With 6.0 rc1 we now publish sha512 checksums for official plugins. However, in order to ease the pain for plugin authors, this commit adds backcompat to still allow sha1 checksums. Also added tests for checksums. Closes #26746
@rjernst @jasontedor As far as I understand the code, we will print a warning message for the community plugins uploaded on Maven Central ( |
@rjernst @jasontedor I have asked to Sonatype to remove the security level on the JIRA issue, they did it very quickly so you should be able to view it now. By the way, I had the confirmation that sha512 is not supported by Maven Central yet, by this person:
|
With 6.0 rc1 we now publish sha512 checksums for official plugins.
However, in order to ease the pain for plugin authors, this commit adds
backcompat to still allow sha1 checksums. Also added tests for
checksums.
closes #26746