Avoid NPE when getting build information #27442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Elasticsearch code is loaded in an unusual classloading environment (e.g., when using the high-level REST client) in Jetty, the code source can be null and we trip with an NPE. This commit addresses this.
jasontedor
added
:Core/Infra/Core
rjernst
approved these changes
Nov 17, 2017
| * Returns path to elasticsearch codebase path | ||
| * The location of the code source for Elasticsearch | ||
| * | ||
| * @return the location of the code source for Elasticsearch which may be null | ||
| */ | ||
| static URL getElasticsearchCodebase() { |
There was a problem hiding this comment.
Maybe just change this to return String so the null handling is completely inside here?
There was a problem hiding this comment.
This was a good suggestion to pursue but we still need the URL instance so we will keep it like this.
jasontedor
added a commit
that referenced
this pull request
Nov 18, 2017
When the Elasticsearch code is loaded in an unusual classloading environment (e.g., when using the high-level REST client) in Jetty, the code source can be null and we trip with an NPE. This commit addresses this. Relates #27442
jasontedor
added a commit
that referenced
this pull request
Nov 18, 2017
When the Elasticsearch code is loaded in an unusual classloading environment (e.g., when using the high-level REST client) in Jetty, the code source can be null and we trip with an NPE. This commit addresses this. Relates #27442
jasontedor
added a commit
that referenced
this pull request
Nov 18, 2017
When the Elasticsearch code is loaded in an unusual classloading environment (e.g., when using the high-level REST client) in Jetty, the code source can be null and we trip with an NPE. This commit addresses this. Relates #27442
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Elasticsearch code is loaded in an unusual classloading environment (e.g., when using the high-level REST client in Jetty), the code source can be null and we trip with an NPE. This commit addresses this.