Deprecate the update_all_types option.
#28284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpountz
added
:Search Foundations/Mapping
cbuescher
reviewed
Jan 18, 2018
| @@ -49,6 +54,9 @@ public RestChannelConsumer prepareRequest(final RestRequest request, final NodeC | |||
| if (request.hasContent()) { | |||
| createIndexRequest.source(request.content(), request.getXContentType()); | |||
| } | |||
| if (request.hasParam("update_all_types")) { | |||
| DEPRECATION_LOGGER.deprecated("[update_all_types] is deprecated since indices may not have more than one type anymore"); | |||
There was a problem hiding this comment.
Maybe it would make sense to put this in createIndexRequest#updateAllTypes, so we also log warnings for Java API users, wdyt?
| @@ -70,6 +75,9 @@ public RestChannelConsumer prepareRequest(final RestRequest request, final NodeC | |||
| PutMappingRequest putMappingRequest = putMappingRequest(Strings.splitStringByCommaToArray(request.param("index"))); | |||
| putMappingRequest.type(request.param("type")); | |||
| putMappingRequest.source(request.requiredContent(), request.getXContentType()); | |||
| if (request.hasParam("update_all_types")) { | |||
| DEPRECATION_LOGGER.deprecated("[update_all_types] is deprecated since indices may not have more than one type anymore"); | |||
There was a problem hiding this comment.
Same here but for putMappingRequest#updateAllTypes.
|
Hmm I had never thought of using the deprecation logger for client-side warnings, I'm not sure what I think about it. However I'd be happy to mark the Java methods as |
|
@jpountz sorry, of course I forgot about the logging infra not being available there. Deprecating the methods makes sense to me though. |
cbuescher
approved these changes
Jan 18, 2018
This option makes no sense on indices that have only one type, which is enforced since 6.0.
jpountz
force-pushed
the
deprecate/update_all_types
branch
from
105707a
to
6520288
Compare
martijnvg
added a commit
that referenced
this pull request
Jan 25, 2018
* es/6.x: [Docs] Fix explanation for `from` and `size` example (#28320) Adapt bwc version after backport #28358 Always return the after_key in composite aggregation response (#28358) Adds a note in the `terms` aggregation docs regarding pagination (#28360) Update packaging tests to work with meta plugins (#28336) Remove Painless Type from MethodWriter in favor of Java Class. (#28346) [Doc] Fixs typo in reverse-nested-aggregation.asciidoc (#28348) [Docs] Fixed Indices information breaking changes (#27914) Reindex: Shore up rethrottle test isHeldByCurrentThread should return primitive bool [Docs] Clarify `html` encoder in highlighting.asciidoc (#27766) Only assert single commit iff index created on 6.2 Deprecate the `update_all_types` option. (#28284) Fix GeoDistance query example Settings: Introduce settings updater for a list of settings (#28338) [Docs] Fix asciidoc style in composite agg docs Adapt bwc version after backport #28310 Adds the ability to specify a format on composite date_histogram source (#28310)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option makes no sense on indices that have only one type, which is
enforced since 6.0.