Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not ignore shard not-available exceptions in replication #28571

Merged
merged 2 commits into from
Feb 8, 2018
Merged

Do not ignore shard not-available exceptions in replication #28571

merged 2 commits into from
Feb 8, 2018

Commits on Feb 8, 2018

  1. Do not ignore shard not-available exceptions in replication 

    The shard not-available exceptions are currently ignored in the
replication as the best effort avoids failing not-yet-ready shards.
However these exceptions can also happen from fully active shards. If
this is the case, we may have skipped important failures from replicas.
Since elastic#28049, only fully initialized shards are received write requests.
This restriction allows us to handle all exceptions in the replication.

There is a side-effect with this change. If a replica retries its peer
recovery second time after being tracked in the replication group, it
can receive replication requests even though it's not-yet-ready. That
shard may be failed and allocated to another node even though it has a
good lucene index on that node.

This PR does not change the way we report replication errors to users,
hence the shard not-available exceptions won't be reported as before.
    @dnhatn
    dnhatn committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    2748ffb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into replication-exception

    @dnhatn
    dnhatn committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    c5d1833 View commit details
    Browse the repository at this point in the history