Inc store reference before refresh #28656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a tragic even happens while we are refreshing a searcher/reader the engine can open new files on a store that is already closed For instance the following CI job failed because a merge was concurrently called on a failing shard: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+oracle-java10-periodic/84 This change increments the ref count of the store during a refresh in order to postpone the closing after a tragic event.
jpountz
approved these changes
Feb 13, 2018
jimczi
added a commit
that referenced
this pull request
Feb 13, 2018
If a tragic even happens while we are refreshing a searcher/reader the engine can open new files on a store that is already closed For instance the following CI job failed because a merge was concurrently called on a failing shard: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+oracle-java10-periodic/84 This change increments the ref count of the store during a refresh in order to postpone the closing after a tragic event.
|
great catch. I think it's trappy that acquiring a lock isn't enough to keep things alive. I think this kind of failure can happen in many other ways. I'm wondering if should increment the store count everytime we issue a lock and decrement it when the lock is freed. Just a thought. This change is great. |
clintongormley
added
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a tragic even happens while we are refreshing a searcher/reader the engine can open new files on a store that is already closed.
For instance the following CI job failed because a refresh was concurrently called on a failing shard:
https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+oracle-java10-periodic/84
This change increments the ref count of the store during a refresh in order to postpone the closing after a tragic event.