Fix Parsing Bug with Update By Query for Stored Scripts #29039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
query for reindex. Closes elastic#28002
jdconrad
added
v7.0.0
v6.3.0
v6.0.3
v6.1.4
v6.2.3
>bug
:Data Management/Indices APIs
|
Pinging @elastic/es-core-infra |
|
@rjernst Thanks for the review! Will commit once CI is successful. |
|
Thanks for fixing this! |
jdconrad
added a commit
that referenced
this pull request
Mar 15, 2018
This changes the parsing logic for stored scripts in update by query to match the parsing logic for scripts in general Elasticsearch. Closes #28002
martijnvg
added a commit
that referenced
this pull request
Mar 16, 2018
* es/6.x: (89 commits) Clarify requirements of strict date formats. (#29090) Clarify that dates are always rendered as strings. (#29093) [Docs] Fix link to Grok patterns (#29088) Fix starting on Windows from another drive (#29086) Use removeTask instead of finishTask in PersistentTasksClusterService (#29055) Added minimal docs for reindex api in java-api docs Allow overriding JVM options in Windows service (#29044) Clarify how to set compiler and runtime JDKs (#29101) Fix Parsing Bug with Update By Query for Stored Scripts (#29039) TEST: write ops should execute under shard permit (#28966) [DOCS] Add X-Pack upgrade details (#29038) Revert "Improve error message for installing plugin (#28298)" Docs: HighLevelRestClient#exists (#29073) Validate regular expressions in dynamic templates. (#29013) [Tests] Fix GetResultTests and DocumentFieldTests failures (#29083) Reenable LiveVersionMapTests.testRamBytesUsed on Java 9. (#29063) Mute failing GetResultTests and DocumentFieldTests [Docs] Fix Java Api index administration usage (#28260) Improve error message for installing plugin (#28298) Decouple XContentBuilder from BytesReference (#28972) ...
|
I am sorry but I have this issue and I am using v6.2.3, so which version should I upgrade to? 6.2.3+ or actually 6.2.3 is fixed? What do those tag means? Affected versions or fixed versions? Thanks for helping |
|
@tom10271 The version tags are the versions that the fix will be released in. At this time, the fix has been merged to our 6.3, 6.x, and master branches so the fix will be in 6.3.0 and all subsequent releases. At this time, 6.3.0 is not released; and I am sure it will disappoint you to know that we do not provide release dates. |
olivere
added a commit
to olivere/elastic
that referenced
this pull request
May 22, 2018
You can now pass `Lang("nil")` or `Lang("null")` in `Script` to set the
language to `null`. This is a workaround for [1] in ES <= 6.3. I will
remove this when 7.x is out.
[1] elastic/elasticsearch#28002
[2] elastic/elasticsearch#29039
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the parsing logic for stored scripts in update by query to match the parsing logic for scripts in general Elasticsearch. Ultimately, this should be changed to use Script.parseScript, but for now this is a much simpler fix to get our users up and going again.
Closes #28002