Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some query extraction bugs. #29283

Merged
merged 1 commit into from
Apr 3, 2018
Merged

Commits on Mar 28, 2018

  1. Fix some query extraction bugs.

    While playing with the percolator I found two bugs:
     - Sometimes we set a min_should_match that is greater than the number of
       extractions. While this doesn't cause direct trouble, it does when the query
       is nested into a boolean query and the boolean query tries to compute the
       min_should_match for the entire query based on its own min_should_match and
       those of the sub queries. So I changed the code to throw an exception when
       min_should_match is greater than the number of extractions.
     - Boolean queries claim matches are verified when in fact they shouldn't. This
       is due to the fact that boolean queries assume that they are verified if all
       sub clauses are verified but things are more complex than that, eg.
       conjunctions that are nested in a disjunction or disjunctions that are nested
       in a conjunction can generally not be verified without running the query.
    jpountz committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    1ac3e7f View commit details
    Browse the repository at this point in the history