Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RepositoriesMetaData variadic constructor #29569

Merged
merged 9 commits into from May 1, 2018

Conversation

hub-cap
Copy link
Contributor

@hub-cap hub-cap commented Apr 17, 2018

The variadic constructor was only used in a few places and the
RepositoriesMetaData class is backed by a List anyway, so just using a
List will make it simpler to instantiate it.

The variadic constructor was only used in a few places and the
RepositoriesMetaData class is backed by a List anyway, so just using a
List will make it simpler to instantiate it.
@hub-cap hub-cap added >non-issue v7.0.0 v6.3.0 >refactoring :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs labels Apr 17, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hub-cap
Copy link
Contributor Author

hub-cap commented Apr 18, 2018

@elasticmachine test this please

@hub-cap
Copy link
Contributor Author

hub-cap commented Apr 27, 2018

run sample packaging tests

@hub-cap
Copy link
Contributor Author

hub-cap commented Apr 30, 2018

run sample packaging tests

1 similar comment
@hub-cap
Copy link
Contributor Author

hub-cap commented Apr 30, 2018

run sample packaging tests

@hub-cap hub-cap merged commit 62a9b89 into elastic:master May 1, 2018
hub-cap added a commit that referenced this pull request May 1, 2018
The variadic constructor was only used in a few places and the
RepositoriesMetaData class is backed by a List anyway, so just using a
List will make it simpler to instantiate it.
dnhatn added a commit that referenced this pull request May 2, 2018
* master: (68 commits)
  [DOCS] Removes X-Pack Elasticsearch release notes (#30272)
  Correct an example in the top-level suggester documentation. (#30224)
  [DOCS] Removes broken link
  [DOCS] Adds file realm configuration details (#30221)
  [DOCS] Adds PKI realm configuration details (#30225)
  Fix a reference to match_phrase_prefix in the match query docs. (#30282)
  Fix failure for validate API on a terms query (#29483)
  [DOCS] Fix 6.4-specific link in changelog (#30314)
  Remove RepositoriesMetaData variadic constructor (#29569)
  Test: increase authentication logging for debugging
  [DOCS] Removes redundant SAML realm settings (#30196)
  REST Client: Add Request object flavored methods (#29623)
  [DOCS] Adds changelog to Elasticsearch Reference (#30271)
  [DOCS] Fixes section error
  SQL: Teach the CLI to ignore empty commands (#30265)
  [DOCS] Adds Active Directory realm configuration details (#30223)
  [DOCS] Removes redundant file realm settings (#30192)
  [DOCS] Fixes users command name (#30275)
  Build: Move gradle wrapper jar to a dot dir (#30146)
  Build: Log a warning if disabling reindex-from-old (#30304)
dnhatn added a commit that referenced this pull request May 2, 2018
* 6.x: (62 commits)
  [DOCS] Adds new installation package details (#29590)
  Revert "Build: Move gradle wrapper jar to a dot dir (#30146)"
  [DOCS] Added 6.3.0 section to changelog
  [DOCS] Merge 6.x release notes into changelog (#30312)
  [DOCS] Removes broken link
  [DOCS] Adds file realm configuration details (#30221)
  [DOCS] Adds PKI realm configuration details (#30225)
  [DOCS] Fix 6.4-specific link in changelog (#30314)
  Remove RepositoriesMetaData variadic constructor (#29569)
  [DOCS] Adds changelog to Elasticsearch Reference (#30310)
  Test: increase authentication logging for debugging
  [DOCS] Removes redundant SAML realm settings (#30196)
  SQL: Teach the CLI to ignore empty commands (#30265)
  [DOCS] Fixes section error
  [DOCS] Adds Active Directory realm configuration details (#30223)
  [DOCS] Removes redundant file realm settings (#30192)
  [DOCS] Fixes users command name (#30275)
  Build: Move gradle wrapper jar to a dot dir (#30146)
  Build: Log a warning if disabling reindex-from-old (#30304)
  TEST: Add debug log to FlushIT
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants