Support for remote path in reindex api #31290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirdolzhenko
added
>enhancement
:Distributed/CRUD
|
Pinging @elastic/es-distributed |
nik9000
reviewed
Jun 13, 2018
| @@ -57,7 +57,7 @@ | |||
| */ | |||
| public class RestReindexAction extends AbstractBaseReindexRestHandler<ReindexRequest, ReindexAction> { | |||
| static final ObjectParser<ReindexRequest, Void> PARSER = new ObjectParser<>("reindex"); | |||
| private static final Pattern HOST_PATTERN = Pattern.compile("(?<scheme>[^:]+)://(?<host>[^:]+):(?<port>\\d+)"); | |||
| private static final Pattern HOST_PATTERN = Pattern.compile("(?<scheme>[^:]+)://(?<host>[^:]+):(?<port>\\d+)(?<pathPrefix>(/.*)?)"); | |||
There was a problem hiding this comment.
Is (?<pathPrefix>/.*)? good enough?
There was a problem hiding this comment.
@nik9000 thanks, you're absolutely right
| @@ -62,10 +63,16 @@ | |||
| private final TimeValue connectTimeout; | |||
|
|
|||
| public RemoteInfo(String scheme, String host, int port, BytesReference query, String username, String password, | |||
| Map<String, String> headers, TimeValue socketTimeout, TimeValue connectTimeout) { | |||
| Map<String, String> headers, TimeValue socketTimeout, TimeValue connectTimeout) { | |||
| this(scheme, host, port, null, query, username, password, headers, socketTimeout, connectTimeout); | |||
There was a problem hiding this comment.
Generally I'd prefer not to add method overrides for this unless we have a zillion uses of the old method. Would you be ok with fixing all of the call sites? Maybe in a followup PR?
There was a problem hiding this comment.
@nik9000 I totally agree with you - there are 11 are call sites - that stopped me to add extra parameter to any of that call site + 10 args... maybe worth to introduce some kind of RemoteInfo.Builder for that purpose ?
|
test this please |
nik9000
approved these changes
Jun 15, 2018
|
Thank @nik9000 for the review |
dnhatn
added a commit
that referenced
this pull request
Jun 19, 2018
* master: Add get stored script and delete stored script to high level REST API - post backport fix Add get stored script and delete stored script to high level REST API (#31355) Core: Combine Action and GenericAction (#31405) Fix reference to XContentBuilder.string() (#31337) Avoid sending duplicate remote failed shard requests (#31313) Fix defaults in GeoShapeFieldMapper output (#31302) RestAPI: Reject forcemerge requests with a body (#30792) Packaging: Remove windows bin files from the tar distribution (#30596) Docs: Use the default distribution to test docs (#31251) [DOCS] Adds testing for security APIs (#31345) Clarify that IP range data can be specified in CIDR notation. (#31374) Use system context for cluster state update tasks (#31241) Percentile/Ranks should return null instead of NaN when empty (#30460) REST high-level client: add validate query API (#31077) Move language analyzers from server to analysis-common module. (#31300) [Test] Fix :example-plugins:rest-handler on Windows Expose lucene's RemoveDuplicatesTokenFilter (#31275) Reload secure settings for plugins (#31383) Remove some cases in FieldTypeLookupTests that are no longer relevant. (#31381) Ensure we don't use a remote profile if cluster name matches (#31331) [TEST] Double write alias fault (#30942) [DOCS] Fix version in SQL JDBC Maven template [DOCS] Improve install and setup section for SQL JDBC SQL: Fix rest endpoint names in node stats (#31371) Support for remote path in reindex api - post backport fix Closes #22913 [ML] Put ML filter API response should contain the filter (#31362) Support for remote path in reindex api (#31290) Add byte array pooling to nio http transport (#31349) Remove trial status info from start trial doc (#31365) [DOCS] Adds links to release notes and highlights add is-write-index flag to aliases (#30942) Add rollover-creation-date setting to rolled over index (#31144) [ML] Hold ML filter items in sorted set (#31338) [Tests] Fix edge case in ScriptedMetricAggregatorTests (#31357)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for remote path in reindex api
Closes #22913