Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not preallocate bytes for channel buffer #31400

Merged
merged 2 commits into from Jun 19, 2018
Merged

Do not preallocate bytes for channel buffer #31400

merged 2 commits into from Jun 19, 2018

Commits on Jun 18, 2018

  1. Do not preallocate bytes for channel buffer 

    Currently, when we open a new channel, we pass it an
InboundChannelBuffer. The channel buffer is preallocated a single 16kb
page. However, there is no guarantee that this channel will be read from
anytime soon. Instead, this commit does not preallocate that page. That
page will be allocated when we receive a read event.
    @Tim-Brooks
    Tim-Brooks committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    65949ea View commit details
    Browse the repository at this point in the history

  2. Fix tests

    @Tim-Brooks
    Tim-Brooks committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    ff7ccd5 View commit details
    Browse the repository at this point in the history