Add more comprehensive tests for field aliases in queries + aggregations. #31565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtibshirani
added
>test
|
Pinging @elastic/es-search-aggs |
9 tasks
jtibshirani
force-pushed
the
field-aliases
branch
from
4890c86
to
4271c55
Compare
jtibshirani
force-pushed
the
field-alias-tests
branch
5 times, most recently
from
f03c51c
to
0cf17d4
Compare
jtibshirani
changed the title
jtibshirani
force-pushed
the
field-alias-tests
branch
from
0cf17d4
to
1dff8c4
Compare
jtibshirani
force-pushed
the
field-alias-tests
branch
5 times, most recently
from
25c1fbe
to
f11b855
Compare
jtibshirani
force-pushed
the
field-aliases
branch
from
2d95123
to
40b5790
Compare
jtibshirani
force-pushed
the
field-alias-tests
branch
2 times, most recently
from
0e1b3a2
to
fc38631
Compare
|
@jpountz this is ready for review (but is not time-sensitive, since I'll be away for a week). |
jtibshirani
commented
Jul 4, 2018
| boolFilterBuilder.add(filter, BooleanClause.Occur.SHOULD); | ||
| } | ||
| return new ConstantScoreQuery(boolFilterBuilder.build()); | ||
| } | ||
|
|
||
| private static Query newLegacyTermQuery(QueryShardContext context, String field) { | ||
| MappedFieldType fieldType = context.fieldMapper(field); |
There was a problem hiding this comment.
I've been a bit concerned that this requirement (to fetch the name of the concrete field type) can be 'trappy' for other developers. I haven't been able to see a way to avoid this, though.
jtibshirani
force-pushed
the
field-alias-tests
branch
from
fc38631
to
ef2d6fc
Compare
jpountz
approved these changes
Jul 17, 2018
| boolFilterBuilder.add(filter, BooleanClause.Occur.SHOULD); | ||
| } | ||
| return new ConstantScoreQuery(boolFilterBuilder.build()); | ||
| } | ||
|
|
||
| private static Query newLegacyTermQuery(QueryShardContext context, String field) { | ||
| MappedFieldType fieldType = context.fieldMapper(field); |
| boolFilterBuilder.add(filter, BooleanClause.Occur.SHOULD); | ||
| } | ||
| return new ConstantScoreQuery(boolFilterBuilder.build()); | ||
| } | ||
|
|
||
| private static Query newLegacyTermQuery(QueryShardContext context, String field) { |
There was a problem hiding this comment.
maybe call it newLegacyExistsQuery instead?
jtibshirani
force-pushed
the
field-alias-tests
branch
from
ef2d6fc
to
384a33a
Compare
jtibshirani
added a commit
that referenced
this pull request
Jul 17, 2018
…ons. (#31565) * Make sure that significant terms aggregations work with field aliases. * Add a test for ValuesSourceConfig. * Allow for subclasses of AggregatorTestCase to provide field aliases. * Add tests for nested and reverse_nested aggregations. * Add an integration test for nested queries. * Add an integration test for 'more like this' queries. * Add tests for querying and loading meta-fields. * Add unit tests for the relevant query builders. * Add integration tests for geo polygon and shape queries. * Fix static analysis violations. * Document that aliases cannot be used in a query lookup path.
jtibshirani
added a commit
that referenced
this pull request
Jul 18, 2018
…ons. (#31565) * Make sure that significant terms aggregations work with field aliases. * Add a test for ValuesSourceConfig. * Allow for subclasses of AggregatorTestCase to provide field aliases. * Add tests for nested and reverse_nested aggregations. * Add an integration test for nested queries. * Add an integration test for 'more like this' queries. * Add tests for querying and loading meta-fields. * Add unit tests for the relevant query builders. * Add integration tests for geo polygon and shape queries. * Fix static analysis violations. * Document that aliases cannot be used in a query lookup path.
jtibshirani
added a commit
that referenced
this pull request
Jul 18, 2018
* Add basic support for field aliases in index mappings. (#31287) * Allow for aliases when fetching stored fields. (#31411) * Add tests around accessing field aliases in scripts. (#31417) * Add documentation around field aliases. (#31538) * Add validation for field alias mappings. (#31518) * Return both concrete fields and aliases in DocumentFieldMappers#getMapper. (#31671) * Make sure that field-level security is enforced when using field aliases. (#31807) * Add more comprehensive tests for field aliases in queries + aggregations. (#31565) * Remove the deprecated method DocumentFieldMappers#getFieldMapper. (#32148)
jtibshirani
added a commit
to jtibshirani/elasticsearch
that referenced
this pull request
Jul 24, 2018
jtibshirani
added a commit
that referenced
this pull request
Jul 24, 2018
* Add basic support for field aliases in index mappings. (#31287) * Allow for aliases when fetching stored fields. (#31411) * Add tests around accessing field aliases in scripts. (#31417) * Return both concrete fields and aliases in DocumentFieldMappers#getMapper. (#31671) * Add documentation around field aliases. (#31538) * Add validation for field alias mappings. (#31518) * Make sure that field-level security is enforced when using field aliases. (#31807) * Add more comprehensive tests for field aliases in queries + aggregations. (#31565) * Remove the deprecated method DocumentFieldMappers#getFieldMapper. (#32148) * Ensure that field aliases cannot be used in multi-fields. (#32219) * Make sure that field aliases count towards the total fields limit. (#32222) * Fix a test bug around nested aggregations and field aliases. (#32287) * Make sure the _uid field is correctly loaded in scripts. * Fix the failing test case FieldLevelSecurityTests#testParentChild_parentField. * Enforce that field aliases can only be specified on indexes with a single type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also fixes some issues uncovered by the tests, largely times when the wrong field name was being used to construct a
Query. I went with unit tests, except for certain query types where integration tests were needed to verify the right behavior.