New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix misspelled words in comments, error messages, and test code #32792
Changes from 3 commits
bee39a3
51822cd
ce6fc35
14b66de
b79b624
420e3b0
76d5d8c
916fa9a
3d13bc8
c67057f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -372,7 +372,7 @@ GET /test_index/_search | |
"percolate" : { | ||
"field" : "query", | ||
"document" : { | ||
"body" : "Bycicles are missing" | ||
"body" : "Bicycles are missing" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @martijnvg I think this change is ok but just checking with you that it wasn't deliberately misspelled for the example. |
||
} | ||
} | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -122,7 +122,7 @@ private void testCancel(String action, AbstractBulkByScrollRequestBuilder<?, ?> | |
logger.debug("waiting for updates to be blocked"); | ||
boolean blocked = awaitBusy( | ||
() -> ALLOWED_OPERATIONS.hasQueuedThreads() && ALLOWED_OPERATIONS.availablePermits() == 0, | ||
1, TimeUnit.MINUTES); // 10 seconds is usually fine but on heavilly loaded machines this can wake a while | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also fixed. |
||
1, TimeUnit.MINUTES); // 10 seconds is usually fine but on heavily loaded machines this can wake a while | ||
assertTrue("updates blocked", blocked); | ||
|
||
// Status should show the task running | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbaiera I can't judge the impact of this change. Ok with you?