Use generic AcknowledgedResponse instead of extended classes #32859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakrone
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
jasontedor
approved these changes
Aug 14, 2018
jasontedor
added a commit
that referenced
this pull request
Aug 15, 2018
* elastic/master: Revert "cluster formation DSL - Gradle integration - part 2 (#32028)" (#32876) cluster formation DSL - Gradle integration - part 2 (#32028) Introduce global checkpoint listeners (#32696) Move connection profile into connection manager (#32858) [ML] Temporarily disabling rolling-upgrade tests Use generic AcknowledgedResponse instead of extended classes (#32859) [ML] Removing old per-partition normalization code (#32816) Use JDK 10 for 6.4 BWC builds (#32866) Removed flaky test. Looks like randomisation makes these assertions unreliable. [test] mute IndexShardTests.testDocStats Introduce the dissect library (#32297) Security: remove password hash bootstrap check (#32440) Move validation to server for put user requests (#32471) [ML] Add high level REST client docs for ML put job endpoint (#32843) Test: Fix forbidden uses in test framework (#32824) Painless: Change fqn_only to no_import (#32817) [test] mute testSearchWithSignificantTermsAgg Watcher: Remove unused hipchat render method (#32211) Watcher: Remove extraneous auth classes (#32300) Watcher: migrate PagerDuty v1 events API to v2 API (#32285)
dakrone
added a commit
that referenced
this pull request
Aug 15, 2018
This removes custom Response classes that extend `AcknowledgedResponse` and do nothing, these classes are not needed and we can directly use the non-abstract super-class instead. While this appears to be a large PR, no code has actually changed, only class names have been changed and entire classes removed.
brusic
added a commit
to brusic/elasticsearch
that referenced
this pull request
Mar 25, 2021
Documentation still refers to DeleteStoredScriptResponse which were removed in elastic#32859
cexbrayat
pushed a commit
to Ninja-Squad/data-discovery
that referenced
this pull request
Mar 10, 2022
Since ES 6.5 breaks it JAVA API and Spring Data is not up to date (only up to 6.4.3 at this moment), we cannot upgrade ES version to 6.5+ without breaking the application because of: elastic/elasticsearch#32859 I think preferable to keep Spring compatible with the ES internal code instead of keeping it in touch with ES server version. The risk to break the ES High Level API is far lower than breaking internals from ES. GNP-5408.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes custom Response classes that extend
AcknowledgedResponseand do nothing, these classes are not needed and we can directly use the non-abstract super-class instead.While this appears to be a large PR, no code has actually changed, only class names have been changed and entire classes removed.