Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix plugin build test on Windows #33078

Merged
merged 2 commits into from Aug 28, 2018
Merged

Fix plugin build test on Windows #33078

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
627f713
Fix plugin build test on Windows
alpar-t Aug 23, 2018
058347f
Add conditional
alpar-t Aug 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion buildSrc/src/test/java/org/elasticsearch/gradle/BuildExamplePluginsIT.java
View file
Open in desktop
Expand Up @@ -158,7 +158,8 @@ private String getLocalTestRepoPath() {
Objects.requireNonNull(property, "test.local-test-repo-path not passed to tests");
File file = new File(property);
assertTrue("Expected " + property + " to exist, but it did not!", file.exists());
return file.getAbsolutePath();
// Use / on Windows too
return file.getAbsolutePath().replace("\\", "/");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to only do the replace on Windows.

}

}