Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce private settings #33327

Merged
merged 13 commits into from Sep 3, 2018
Merged

Commits on Aug 31, 2018

  1. Introduce private settings

    This commit introduces the formal notion of a private setting. This
    enables us to register some settings that we had previously not
    registered as fully-fledged settings to avoid them being exposed via
    APIs such as the create index API. For example, we had hacks in the
    codebase to allow index.version.created to be passed around inside of
    settings objects, but was not registered as a setting so that if a user
    tried to use the setting on any API then they would get an
    exception. This prevented users from setting index.version.created on
    index creation, or updating it via the index settings API. By
    introducing private settings, we can continue to reject these attempts,
    yet now we can represent these settings as actual settings. In this
    change, we register index.version.created as an actual setting. We do
    not cutover all settings that we had been treating as private in this
    pull request, it is already quite large due to moving some tests around
    to account for the fact that some tests need to be able to set the
    index.version.created. This can be done in a follow-up change.
    jasontedor committed Aug 31, 2018
    Copy the full SHA
    397ae06 View commit details
    Browse the repository at this point in the history
  2. Remove import

    jasontedor committed Aug 31, 2018
    Copy the full SHA
    0590fc4 View commit details
    Browse the repository at this point in the history
  3. Remove dead method

    jasontedor committed Aug 31, 2018
    Copy the full SHA
    80b10c9 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    da05111 View commit details
    Browse the repository at this point in the history
  5. Fix missing imports

    jasontedor committed Aug 31, 2018
    Copy the full SHA
    ad44713 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2018

  1. Another unused import

    jasontedor committed Sep 1, 2018
    Copy the full SHA
    511ab55 View commit details
    Browse the repository at this point in the history
  2. Fix typo

    jasontedor committed Sep 1, 2018
    Copy the full SHA
    9e3ab66 View commit details
    Browse the repository at this point in the history
  3. Simplify

    jasontedor committed Sep 1, 2018
    Copy the full SHA
    a1e7f0c View commit details
    Browse the repository at this point in the history
  4. More simplification

    jasontedor committed Sep 1, 2018
    Copy the full SHA
    6a8b9de View commit details
    Browse the repository at this point in the history
  5. More cleanup

    jasontedor committed Sep 1, 2018
    Copy the full SHA
    ad83c65 View commit details
    Browse the repository at this point in the history
  6. Again with the imports

    jasontedor committed Sep 1, 2018
    Copy the full SHA
    542be5c View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2018

  1. Merge branch 'master' into private-index-settings

    * master: (197 commits)
      Prevent NPE parsing the stop datafeed request. (elastic#33347)
      HLRC: Add ML get overall buckets API (elastic#33297)
      Core: Fix epoch millis java time formatter (elastic#33302)
      [Docs] Improve tuning for speed advice (elastic#33315)
      [Rollup] Fix Caps Comparator to handle calendar/fixed time (elastic#33336)
      [CI] Mute  IndexShardTests#testIndexCheckOnStartup fails elastic#33345
      [CI] Mute LuceneChangesSnapshotTests#testUpdateAndReadChangesConcurrently
      Security for _field_names field should not override field statistics (elastic#33261)
      Add early termination support to BucketCollector (elastic#33279)
      Fix extractjar task  ci  (elastic#33272)
      Mute testFollowIndexAndCloseNode
      Logging: Drop Settings from some logging ctors (elastic#33332)
      HLREST: add update by query API (elastic#32760)
      TEST: Increase timeout testFollowIndexAndCloseNode (elastic#33333)
      HLRC: ML Flush job (elastic#33187)
      HLRC: Adding ML Job stats (elastic#33183)
      LLREST: Drop deprecated methods (elastic#33223)
      Mute testSyncerOnClosingShard
      [DOCS] Moves machine learning APIs to docs folder (elastic#31118)
      Mute test watcher usage stats output
      ...
    jasontedor committed Sep 3, 2018
    Copy the full SHA
    ffd8db7 View commit details
    Browse the repository at this point in the history
  2. Review comment

    jasontedor committed Sep 3, 2018
    Copy the full SHA
    635da8b View commit details
    Browse the repository at this point in the history