-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native roles store uses mget to retrieve roles #33531
Merged
Merged
Commits on Sep 7, 2018
-
Native roles store uses mget to retrieve roles
The native roles store previously would issue a search if attempting to retrieve more than a single role. This is fine when we are attempting to retrieve all of the roles to list them in the api, but could cause issues when attempting to find roles for a user. The search is not prioritized over other search requests, so heavy aggregations/searches or overloaded nodes could cause roles to be cached as missing if the search is rejected. When attempting to load specific roles, we know the document id for the role that we are trying to load, which allows us to use the multi-get api for loading these roles. This change makes use of the multi-get api when attempting to load more than one role by name. This api is also constrained by a threadpool but the tasks in the GET threadpool should be quicker than searches. See elastic#33205
Configuration menu - View commit details
-
Copy full SHA for 629b4a2 - Browse repository at this point
Copy the full SHA 629b4a2View commit details
Commits on Sep 11, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 2be96aa - Browse repository at this point
Copy the full SHA 2be96aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for a4016e4 - Browse repository at this point
Copy the full SHA a4016e4View commit details
Commits on Sep 12, 2018
-
Configuration menu - View commit details
-
Copy full SHA for df8e6b9 - Browse repository at this point
Copy the full SHA df8e6b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac0eda9 - Browse repository at this point
Copy the full SHA ac0eda9View commit details
Commits on Oct 15, 2018
-
Configuration menu - View commit details
-
Copy full SHA for c5d2a63 - Browse repository at this point
Copy the full SHA c5d2a63View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c9d0af - Browse repository at this point
Copy the full SHA 7c9d0afView commit details
Commits on Oct 16, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 7266147 - Browse repository at this point
Copy the full SHA 7266147View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3aaf5af - Browse repository at this point
Copy the full SHA 3aaf5afView commit details -
Configuration menu - View commit details
-
Copy full SHA for ada770a - Browse repository at this point
Copy the full SHA ada770aView commit details
Commits on Oct 22, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 453323d - Browse repository at this point
Copy the full SHA 453323dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3da780b - Browse repository at this point
Copy the full SHA 3da780bView commit details
Commits on Oct 24, 2018
-
Configuration menu - View commit details
-
Copy full SHA for f958999 - Browse repository at this point
Copy the full SHA f958999View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b707cd - Browse repository at this point
Copy the full SHA 7b707cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 27dabe6 - Browse repository at this point
Copy the full SHA 27dabe6View commit details -
Configuration menu - View commit details
-
Copy full SHA for fbadafd - Browse repository at this point
Copy the full SHA fbadafdView commit details
Commits on Oct 25, 2018
-
Configuration menu - View commit details
-
Copy full SHA for aae1861 - Browse repository at this point
Copy the full SHA aae1861View commit details
Commits on Oct 26, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 1b4af47 - Browse repository at this point
Copy the full SHA 1b4af47View commit details -
Configuration menu - View commit details
-
Copy full SHA for bab7819 - Browse repository at this point
Copy the full SHA bab7819View commit details
Commits on Oct 29, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 80f645c - Browse repository at this point
Copy the full SHA 80f645cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c8db29e - Browse repository at this point
Copy the full SHA c8db29eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.