Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watcher: Reduce script cache churn by checking for mustache tags #33978

Merged

Commits on Sep 24, 2018

  1. Watcher: Reduce script cache churn by checking for mustache tags

    Watcher is using a lot of so called TextTemplate fields in a watch
    definition, which can use mustache to insert the watch id for example.
    For the user it is non-obvious which field is just a string field or
    which field is a text template.
    
    This also means, that for every such field, we currently do a script
    compilation, even if the field does not contain any mustache syntax.
    
    This will lead to an increased script cache churn, because those
    compiled scripts (that only contain a string), will evict other scripts.
    On top of that, this also means that an unneeded compilation has
    happened, instead of returning that string immediately.
    
    The usages of mustache templating are in all of the actions (most of the time far
    more than one compilation) as well as most of the inputs.
    
    Especially when running a lot of watches in parallel, this will reduce
    execution times and help reuse of real scripts.
    spinscale committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    28e2c81 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2018

  1. Configuration menu
    Copy the full SHA
    beb7906 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2018

  1. Configuration menu
    Copy the full SHA
    76424f4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d0eaee4 View commit details
    Browse the repository at this point in the history