Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging: Drop two deprecated methods #34055

Merged
merged 1 commit into from Sep 26, 2018

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Sep 25, 2018

This drops two deprecated methods from ESLoggerFactory, switching all
calls to those methods to calls to methods of the same name on
LogManager.

This drops two deprecated methods from `ESLoggerFactory`, switching all
calls to those methods to calls to methods of the same name on
`LogManager`.
@nik9000 nik9000 added :Core/Infra/Logging Log management and logging utilities v7.0.0 >refactoring v6.5.0 labels Sep 25, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@nik9000 nik9000 merged commit ddce970 into elastic:master Sep 26, 2018
nik9000 added a commit that referenced this pull request Sep 26, 2018
This drops two deprecated methods from `ESLoggerFactory`, switching all
calls to those methods to calls to methods of the same name on
`LogManager`.
atript8 pushed a commit to atript8/elasticsearch that referenced this pull request Sep 28, 2018
This drops two deprecated methods from `ESLoggerFactory`, switching all
calls to those methods to calls to methods of the same name on
`LogManager`.
kcm pushed a commit that referenced this pull request Oct 30, 2018
This drops two deprecated methods from `ESLoggerFactory`, switching all
calls to those methods to calls to methods of the same name on
`LogManager`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants