Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parent-aggregation to parent-join module #34210

Merged
merged 9 commits into from Nov 8, 2018
Merged

Add parent-aggregation to parent-join module #34210

merged 9 commits into from Nov 8, 2018

Commits on Oct 2, 2018

  1. First steps for adding Parent-Aggregation to parent-join module

    @centic9
    centic9 committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    b6e186c View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2018

  1. Add check to not collect buckets multiple times if not needed 

    As stated in the PR, we can avoid collecting buckets into the
multiple-array as long as it is the same bucket as before
    @centic9
    centic9 committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    a86a159 View commit details
    Browse the repository at this point in the history

  2. Combine parent-join aggregator functionality and remove seenParents 

    We can combine both aggregators into an abstract class, only the filter
needs to be defined differently.

Also the lookup via seenParents is not necessary any more after the
previous change.
    @centic9
    centic9 committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    fbcf9b0 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2018

  1. Merge remote-tracking branch 'origin/master' into parent_join_parent_… 

    …aggregation
    @centic9
    centic9 committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    6e6edf7 View commit details
    Browse the repository at this point in the history

  2. Rework parent-aggregation after work in PR elastic#34845 

    The required changes are now even less as the new base class
ParentJoinAggregator implements collecting buckets in a different
way.
    @centic9
    centic9 committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    b73af5a View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2018

  1. Adjust tests for parent-aggregation some more based on review-comments 

    Adjust import/javadoc, remove commented code/TODOs
    @centic9
    centic9 committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    01aa7d0 View commit details
    Browse the repository at this point in the history

  2. Abstract base class for tests needs to be named ...TestCase

    @centic9
    centic9 committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    769ad0f View commit details
    Browse the repository at this point in the history

  3. Add documentation for parent-aggregation similar to children-aggregation

    @centic9
    centic9 committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    d37af45 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2018

  1. Merge remote-tracking branch 'origin/master' into parent_join_parent_… 

    …aggregation
    @centic9
    centic9 committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    0fec20a View commit details
    Browse the repository at this point in the history