Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for null argument is already done in splitStringByCommaToArray #34268

Merged
merged 3 commits into from Oct 24, 2018
Merged

check for null argument is already done in splitStringByCommaToArray #34268

merged 3 commits into from Oct 24, 2018

Conversation

scampi
Copy link
Contributor

@scampi scampi commented Oct 3, 2018

No description provided.

@colings86 colings86 added the :Search/Search Search-related issues that do not fall into other categories label Oct 3, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@javanna
Copy link
Member

javanna commented Oct 3, 2018

test this please

@javanna javanna self-requested a review October 3, 2018 19:08
@scampi
Copy link
Contributor Author

scampi commented Oct 3, 2018

Something went wrong when compiling:

20:17:42   [bwc] A problem occurred evaluating project ':benchmarks'.
20:17:42   [bwc] > Failed to apply plugin [id 'elasticsearch.build']
20:17:42   [bwc]    > the compiler java.home must be set to a JDK installation directory for Java 11 but is [/var/lib/jenkins/.java/java10] corresponding to [1.10]

@rjernst
Copy link
Member

rjernst commented Oct 3, 2018

We switched our builds to use java 11 today. This looks like it was caught in the middle. I will trigger another build.

@elasticmachine test this please

@scampi
Copy link
Contributor Author

scampi commented Oct 4, 2018

@rjernst I think the same error happened again, isn't it ?

@javanna
Copy link
Member

javanna commented Oct 11, 2018

retest this please

2 similar comments
@javanna
Copy link
Member

javanna commented Oct 22, 2018

retest this please

@javanna
Copy link
Member

javanna commented Oct 22, 2018

retest this please

@javanna
Copy link
Member

javanna commented Oct 23, 2018

retest this please

@scampi
Copy link
Contributor Author

scampi commented Oct 23, 2018

The build fails with the following error, however, it seems there is an open fix for that at #34683

11:58:25 > Task :x-pack:plugin:ml:qa:single-node-tests:integTestRunner FAILED
11:58:25 Slow Tests Summary:
11:58:25   1.07s | org.elasticsearch.xpack.ml.transforms.PainlessDomainSplitIT

@javanna
Copy link
Member

javanna commented Oct 24, 2018

retest this please

@javanna javanna merged commit 04f3e67 into elastic:master Oct 24, 2018
@javanna
Copy link
Member

javanna commented Oct 24, 2018

thanks @scampi !

@scampi scampi deleted the extra-check branch October 25, 2018 07:13
kcm pushed a commit that referenced this pull request Oct 30, 2018
@scampi @kcm
Remove redundant method from RestClearScrollAction (#34268)
d44cc7e 
The check for null argument is already done in `splitStringByCommaToArray`, hence it can be removed, which allows us to remove the whole splitScrollIds private method.
javanna pushed a commit that referenced this pull request Nov 1, 2018
@scampi @javanna
Remove redundant method from RestClearScrollAction (#34268)
fbb5c10 
The check for null argument is already done in `splitStringByCommaToArray`, hence it can be removed, which allows us to remove the whole splitScrollIds private method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javanna javanna Awaiting requested review from javanna

Assignees
No one assigned
Labels
>enhancement :Search/Search Search-related issues that do not fall into other categories v6.6.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@scampi @elasticmachine @javanna @rjernst @colings86