[CCR] Add qa test library #34611
Merged
[CCR] Add qa test library #34611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test code duplication.
martijnvg
added
>non-issue
:Distributed/CCR
|
Pinging @elastic/es-distributed |
nik9000
reviewed
Oct 18, 2018
| @@ -5,6 +5,7 @@ apply plugin: 'elasticsearch.standalone-test' | |||
| dependencies { | |||
| testCompile project(path: xpackModule('core'), configuration: 'testArtifacts') | |||
| testCompile project(path: xpackModule('ccr'), configuration: 'runtime') | |||
| testCompile project(':x-pack:plugin:ccr:qa:test-common') | |||
There was a problem hiding this comment.
SQL has this and it sticks it in qa.
There was a problem hiding this comment.
Well, it is in x-pack/qa/sql now, but I'm in the process of moving it to x-pack/plugin/sql/qa.
There was a problem hiding this comment.
That is a much better idea than adding another gradle module. So I did this: 633afa7
There was a problem hiding this comment.
and here is the second half of the change: 772a4f8
jasontedor
approved these changes
Oct 23, 2018
x-pack/plugin/ccr/qa/build.gradle
Outdated
| @@ -1,5 +1,14 @@ | |||
| import org.elasticsearch.gradle.test.RestIntegTestTask | |||
|
|
|||
| apply plugin: 'elasticsearch.build' | |||
|
|
|||
| archivesBaseName = 'ccr-qa-test-common' | |||
martijnvg
added a commit
that referenced
this pull request
Oct 23, 2018
* Introduced test qa lib that all CCR qa modules depend on to avoid test code duplication.
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
* Introduced test qa lib that all CCR qa modules depend on to avoid test code duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced test qa lib that all CCR qa modules depend on in order to avoid test code duplication.
All qa multi node tests now extend from a new base class that adds several helper methods.