Add stop rollup job support to HL REST Client #34702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds support for stoping a rollup job to the High Level REST Client. Relates to elastic#29827
cbuescher
force-pushed
the
HLClient-addStopJob
branch
from
96a3e46
to
ce3bc14
Compare
cbuescher
added
the
:StorageEngine/Rollup
|
Pinging @elastic/es-search-aggs |
|
@elasticmachine test this please |
98 tasks
cbuescher
force-pushed
the
HLClient-addStopJob
branch
from
ba0b58b
to
0bab324
Compare
|
Rollup stuff LGTM. The client stuff does too, but I'll let @hub-cap cover that if he wants :) Aside and unrelated to this PR: we should probably adjust |
hub-cap
approved these changes
Nov 13, 2018
client/rest-high-level/src/main/java/org/elasticsearch/client/RollupRequestConverters.java
Outdated
Show resolved
Hide resolved
client/rest-high-level/src/main/java/org/elasticsearch/client/RollupRequestConverters.java
Outdated
Show resolved
Hide resolved
client/rest-high-level/src/main/java/org/elasticsearch/client/RollupRequestConverters.java
Outdated
Show resolved
Hide resolved
client/rest-high-level/src/test/java/org/elasticsearch/client/RollupRequestConvertersTests.java
Outdated
Show resolved
Hide resolved
|
@hub-cap thanks for the review, I pushed another commit adressing your comments and am waiting on the green light from CI now. |
|
@elasticmachine test this please |
cbuescher
pushed a commit
that referenced
this pull request
Nov 14, 2018
This change adds support for stoping a rollup job to the High Level REST Client. Relates to #29827
tomcallahan
removed
the
:StorageEngine/Rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for stoping a rollup job to the High Level REST Client.
Relates to #29827